fix: cache block index instead of block offset - #534
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 76.95% 76.87% -0.09%
==========================================
Files 248 248
Lines 18837 18845 +8
==========================================
- Hits 14496 14487 -9
- Misses 4341 4358 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
forshev
approved these changes
Sep 23, 2026
eguguchkin
approved these changes
Sep 29, 2026
dkharms
force-pushed
the
531-fix-key
branch
from
September 29, 2026 07:48
55f9e73 to
89a6e55
Compare
dkharms
enabled auto-merge (squash)
September 29, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pull request I've reworked caching for
DocBlock-- now as a key we use block index not the block offset (I guess, 2^32 blocks will be more than enough).Fixes #531
If you have used LLM/AI assistance please provide model name and full prompt: